mirror of
https://github.com/NanmiCoder/cc-haha
synced 2026-07-16 13:03:31 +08:00
b156be8d8d
Contributors and coding agents need one local command that both reports and enforces the quality contract. This change turns the PR gate into the shared verification entrypoint, adds path-selected local lanes, tightens coverage accounting around changed lines, and documents the repair loop in contributor and agent-facing guidance. Constraint: Ordinary PR verification must stay non-live and runnable without provider credentials Constraint: Coverage policy updates in this commit require maintainer approval before push/merge Rejected: Keep quality guidance only in docs | agents need executable scripts and AGENTS.md instructions to follow the loop consistently Confidence: high Scope-risk: broad Directive: Do not bypass `bun run verify` for production changes; fix failed lanes and coverage reports instead of lowering thresholds Tested: bun run check:policy Tested: ALLOW_CLI_CORE_CHANGE=1 ALLOW_COVERAGE_BASELINE_CHANGE=1 bun run verify Not-tested: live provider baseline; no provider credentials were required for this non-live PR gate
34 lines
1.8 KiB
Markdown
34 lines
1.8 KiB
Markdown
## Summary
|
|
|
|
|
|
## Feature Quality Contract
|
|
|
|
- Changed surface: <!-- desktop / server / adapter / native / docs / provider-runtime / agent-loop / release -->
|
|
- Tests added or updated:
|
|
- <!-- e.g. unit/component/API/request-shape/workflow/E2E -->
|
|
- Coverage evidence:
|
|
- <!-- coverage report path + relevant suite summary + changed-line coverage -->
|
|
- E2E / live-model evidence:
|
|
- <!-- command + report path, or explicit blocker such as no provider/quota -->
|
|
- Known risk / rollback:
|
|
- <!-- remaining risk and how to revert safely -->
|
|
|
|
## Verification
|
|
|
|
- [ ] I ran the relevant local checks, or explained why they do not apply.
|
|
- [ ] I added or updated same-area tests for every production behavior change.
|
|
- [ ] I ran `bun run verify` for code changes, including the coverage gate.
|
|
- [ ] New or changed executable production lines meet the changed-line coverage threshold, or the blocker/maintainer override is documented.
|
|
- [ ] I attached or summarized the quality report path, JUnit/log artifact path, and pass/fail/skip counts.
|
|
- [ ] I ran E2E/live smoke for cross-boundary, provider/runtime, desktop chat, agent-loop, native, or release changes, or documented the blocker.
|
|
|
|
## Risk
|
|
|
|
- [ ] This PR does not touch CLI core paths, or it has maintainer approval for `allow-cli-core-change`.
|
|
- [ ] Production code changes include matching tests, or have maintainer approval for `allow-missing-tests`.
|
|
- [ ] Coverage baseline/threshold changes have maintainer approval for `allow-coverage-baseline-change`.
|
|
- [ ] Quarantined tests still have owners, exit criteria, and unexpired review windows.
|
|
- [ ] Provider/runtime changes were covered by mock contract tests, and live smoke was run or explicitly deferred.
|
|
|
|
@dosubot review this PR for changed-area risk, missing tests, docs impact, desktop startup risk, and CLI core impact.
|