cc-haha/desktop/src/components/common/OpenWithMenu.test.tsx
程序员阿江(Relakkes) 34fe0761d2 fix(desktop): improve in-app browser preview menus (#761)
Tested: cd desktop && bun run test -- src/components/common/OpenWithMenu.test.tsx src/components/workspace/WorkspaceFileOpenWith.test.tsx src/components/browser/BrowserSurface.test.tsx src/lib/handlePreviewLink.test.ts src/lib/openWithContextForHref.test.ts

Tested: bun run check:desktop

Confidence: high

Scope-risk: narrow
2026-06-12 16:23:04 +08:00

152 lines
6.4 KiB
TypeScript

import '@testing-library/jest-dom'
import { fireEvent, render, screen } from '@testing-library/react'
import { describe, expect, it, vi } from 'vitest'
import { OpenWithMenu } from './OpenWithMenu'
import type { OpenWithItem } from '../../lib/openWithItems'
const anchor = { top: 100, bottom: 110, left: 20, right: 120 }
function makeItems(onSelect1 = vi.fn(), onSelect2 = vi.fn(), onSelect3 = vi.fn()): OpenWithItem[] {
return [
{ id: 'in-app', label: 'In-app browser', icon: 'in-app-browser', onSelect: onSelect1 },
{ id: 'system', label: 'System browser', icon: 'system', onSelect: onSelect2 },
{ id: 'preview', label: 'Workspace preview', icon: 'preview', onSelect: onSelect3 },
]
}
describe('OpenWithMenu', () => {
it('renders all item labels', () => {
const onClose = vi.fn()
render(<OpenWithMenu items={makeItems()} anchor={anchor} onClose={onClose} />)
expect(screen.getByText('In-app browser')).toBeInTheDocument()
expect(screen.getByText('System browser')).toBeInTheDocument()
expect(screen.getByText('Workspace preview')).toBeInTheDocument()
})
it('renders a menu role', () => {
const onClose = vi.fn()
render(<OpenWithMenu items={makeItems()} anchor={anchor} onClose={onClose} />)
expect(screen.getByRole('menu')).toBeInTheDocument()
})
it('renders menuitems for each item', () => {
const onClose = vi.fn()
render(<OpenWithMenu items={makeItems()} anchor={anchor} onClose={onClose} />)
const menuItems = screen.getAllByRole('menuitem')
expect(menuItems).toHaveLength(3)
})
it('clicking an item calls its onSelect and onClose', () => {
const onClose = vi.fn()
const onSelect1 = vi.fn()
render(<OpenWithMenu items={makeItems(onSelect1)} anchor={anchor} onClose={onClose} />)
fireEvent.click(screen.getByText('In-app browser'))
expect(onSelect1).toHaveBeenCalledTimes(1)
expect(onClose).toHaveBeenCalledTimes(1)
})
it('clicking the second item calls its onSelect and onClose', () => {
const onClose = vi.fn()
const onSelect2 = vi.fn()
render(<OpenWithMenu items={makeItems(vi.fn(), onSelect2)} anchor={anchor} onClose={onClose} />)
fireEvent.click(screen.getByText('System browser'))
expect(onSelect2).toHaveBeenCalledTimes(1)
expect(onClose).toHaveBeenCalledTimes(1)
})
it('pressing Escape calls onClose', () => {
const onClose = vi.fn()
render(<OpenWithMenu items={makeItems()} anchor={anchor} onClose={onClose} />)
fireEvent.keyDown(document, { key: 'Escape' })
expect(onClose).toHaveBeenCalledTimes(1)
})
it('mousedown outside the menu calls onClose', () => {
const onClose = vi.fn()
render(<OpenWithMenu items={makeItems()} anchor={anchor} onClose={onClose} />)
// Simulate mousedown on document body (outside the menu)
fireEvent.mouseDown(document.body)
expect(onClose).toHaveBeenCalledTimes(1)
})
it('scrolling the viewport calls onClose', () => {
const onClose = vi.fn()
render(<OpenWithMenu items={makeItems()} anchor={anchor} onClose={onClose} />)
fireEvent.scroll(window)
expect(onClose).toHaveBeenCalledTimes(1)
})
describe('triggerEl exclusion (re-click-trigger toggle support)', () => {
it('does NOT call onClose when mousedown lands inside triggerEl', () => {
// Set up a trigger element + a child within it in the document.
const trigger = document.createElement('button')
const triggerChild = document.createElement('span')
trigger.appendChild(triggerChild)
document.body.appendChild(trigger)
const onClose = vi.fn()
render(<OpenWithMenu items={makeItems()} anchor={anchor} onClose={onClose} triggerEl={trigger} />)
// mousedown on the trigger itself
fireEvent.mouseDown(trigger)
expect(onClose).not.toHaveBeenCalled()
// mousedown on a descendant of the trigger
fireEvent.mouseDown(triggerChild)
expect(onClose).not.toHaveBeenCalled()
document.body.removeChild(trigger)
})
it('STILL calls onClose for true outside clicks (not menu, not trigger)', () => {
const trigger = document.createElement('button')
document.body.appendChild(trigger)
const outside = document.createElement('div')
document.body.appendChild(outside)
const onClose = vi.fn()
render(<OpenWithMenu items={makeItems()} anchor={anchor} onClose={onClose} triggerEl={trigger} />)
fireEvent.mouseDown(outside)
expect(onClose).toHaveBeenCalledTimes(1)
document.body.removeChild(trigger)
document.body.removeChild(outside)
})
it('Escape still closes when triggerEl is provided', () => {
const trigger = document.createElement('button')
document.body.appendChild(trigger)
const onClose = vi.fn()
render(<OpenWithMenu items={makeItems()} anchor={anchor} onClose={onClose} triggerEl={trigger} />)
fireEvent.keyDown(document, { key: 'Escape' })
expect(onClose).toHaveBeenCalledTimes(1)
document.body.removeChild(trigger)
})
it('item click still closes the menu when triggerEl is provided', () => {
const trigger = document.createElement('button')
document.body.appendChild(trigger)
const onClose = vi.fn()
const onSelect1 = vi.fn()
render(<OpenWithMenu items={makeItems(onSelect1)} anchor={anchor} onClose={onClose} triggerEl={trigger} />)
fireEvent.click(screen.getByText('In-app browser'))
expect(onSelect1).toHaveBeenCalledTimes(1)
expect(onClose).toHaveBeenCalledTimes(1)
document.body.removeChild(trigger)
})
})
it('flips above the anchor when it would overflow the viewport bottom', () => {
// The trigger often sits right above the composer; the menu must not render off-screen below it.
Object.defineProperty(window, 'innerHeight', { value: 300, configurable: true })
Object.defineProperty(window, 'innerWidth', { value: 1000, configurable: true })
const rectSpy = vi.spyOn(HTMLElement.prototype, 'getBoundingClientRect').mockReturnValue({
height: 200, width: 220, top: 0, left: 0, right: 0, bottom: 0, x: 0, y: 0, toJSON: () => ({}),
} as DOMRect)
// anchor near the bottom: top:260/bottom:270. Down would be 276, 276+200=476 > 300-8 ⇒ flip up.
render(<OpenWithMenu items={makeItems()} anchor={{ top: 260, bottom: 270, left: 20, right: 120 }} onClose={vi.fn()} />)
// flipped top = anchor.top - height - 6 = 260 - 200 - 6 = 54
expect(screen.getByRole('menu').style.top).toBe('54px')
rectSpy.mockRestore()
})
})