mirror of
https://github.com/NanmiCoder/cc-haha
synced 2026-07-27 15:13:37 +08:00
d59819c5c3
Two fork-vs-upstream gaps surfaced when PR Quality ran against
8d914596 (the upstream v0.4.1 merge):
1. `bun run check:policy` failed with `Cannot find package 'yaml'`
because the change-policy job in pr-quality.yml had no
`bun install` step. Other lanes (server-checks, desktop-checks,
adapter-checks, coverage-checks) all install root deps before
running their checks; change-policy was the outlier. Upstream's
release-update-metadata.test.ts started importing `yaml` from
the root package.json, so the missing install step finally bit.
Fix: add the missing `bun install` step. Lockfile already pins
yaml@2.8.3, so this is a no-op everywhere else.
2. Two assertions in scripts/pr/release-workflow.test.ts were
written against the upstream identity (NanmiCoder/cc-haha) but
commit 3cbed50c on this fork repointed desktop/package.json
`homepage` and `build.publish.owner` to 706412584/cc-haha
without updating the tests. The merge brought the upstream
tests forward and the fork-only desktop config conflict was
immediately. Both assertions are now fork-friendly:
- homepage: regex `https://github.com/<owner>/cc-haha`
- publish: explicit github provider + repo cc-haha, owner
can be any non-empty identifier.
Author name/email and Linux maintainer assertions are kept
strict because commit 3cbed50c intentionally preserved them.
Tested:
- `bun run check:policy` locally: 81/83 pass. The single
remaining failure (`release workflow records macOS signing
state and warns for unsigned builds`) is a Windows-only CRLF
mismatch in a regex that uses `fi\n` against a workflow file
with CRLF line endings. CI runs on Ubuntu and the test passes
upstream, so this does not block the PR.
Confidence: high
Scope-risk: narrow (CI workflow + test, no product code touched).