mirror of
https://github.com/NanmiCoder/cc-haha
synced 2026-07-16 13:03:31 +08:00
Introduce the Electron desktop shell alongside the existing React renderer and local Bun server boundary. The migration keeps the DesktopHost contract explicit across Tauri, Electron, and browser runtimes while adding Electron main/preload services for dialogs, shell, notifications, updates, tray/window lifecycle, terminal, preview WebContentsView, app mode, and release/package validation.
The commit also carries the latest local main desktop command updates, including agent slash entries and hidden-by-default markdown thinking details, so the packaged Electron build matches the current main UX surface.
Constraint: React renderer, local Bun server, REST/WebSocket, and sidecar boundaries must remain reusable during the migration
Constraint: macOS dev packages are ad-hoc signed and cannot prove Developer ID notarization or Gatekeeper release launch
Rejected: Browser-only smoke validation | it cannot exercise native dialogs, keychain prompts, notification behavior, or packaged app startup
Confidence: medium
Scope-risk: broad
Directive: Do not remove Tauri host support until signed Electron release artifacts pass native OS smoke on macOS, Windows, and Linux
Tested: bun run check:desktop
Tested: cd desktop && bun run check:electron
Tested: CSC_IDENTITY_AUTO_DISCOVERY=false bun run electron📦dir
Tested: bun run test:package-smoke --platform macos --package-kind dir --artifacts-dir desktop/build-artifacts/electron
Tested: Computer Use read packaged Electron app window at desktop/build-artifacts/electron/mac-arm64/Claude Code Haha.app
Not-tested: Developer ID signed/notarized Gatekeeper launch
Not-tested: Real OS notification click-to-session action
Not-tested: Windows and Linux packaged app smoke on real hosts
88 lines
5.0 KiB
TypeScript
88 lines
5.0 KiB
TypeScript
import { describe, expect, test } from 'bun:test'
|
|
import { readFileSync } from 'node:fs'
|
|
|
|
describe('feature quality contract', () => {
|
|
test('keeps the agent-facing implementation contract explicit', () => {
|
|
const agents = readFileSync('AGENTS.md', 'utf8')
|
|
|
|
expect(agents).toContain('## Feature Quality Contract')
|
|
expect(agents).toContain('## Persistent Storage Compatibility')
|
|
expect(agents).toContain('Any change to local JSON, `localStorage`, or app config persistence formats must ship with a forward migration')
|
|
expect(agents).toContain('`~/.claude/settings.json` is user-owned shared state')
|
|
expect(agents).toContain('persistence upgrade gate')
|
|
expect(agents).toContain('Production code changes under `desktop/src`, `src/server`, `src/tools`, `src/utils`, or `adapters` must include a same-area test file')
|
|
expect(agents).toContain('Coverage is part of the feature, not an afterthought.')
|
|
expect(agents).toContain('changed executable production line must meet the changed-line coverage gate')
|
|
expect(agents).toContain('E2E is required when the feature crosses process boundaries')
|
|
expect(agents).toContain('AI agents must include this evidence')
|
|
expect(agents).toContain('Unified local entrypoint: `bun run verify`')
|
|
expect(agents).toContain('If `bun run verify` fails, do not stop at reporting the failure')
|
|
})
|
|
|
|
test('keeps PR authors accountable for tests, coverage, E2E, and risk', () => {
|
|
const template = readFileSync('.github/pull_request_template.md', 'utf8')
|
|
|
|
expect(template).toContain('## Feature Quality Contract')
|
|
expect(template).toContain('Changed surface:')
|
|
expect(template).toContain('Tests added or updated:')
|
|
expect(template).toContain('Coverage evidence:')
|
|
expect(template).toContain('changed-line coverage')
|
|
expect(template).toContain('E2E / live-model evidence:')
|
|
expect(template).toContain('Known risk / rollback:')
|
|
expect(template).toContain('I added or updated same-area tests')
|
|
})
|
|
|
|
test('keeps the one-command verification entrypoint documented', () => {
|
|
const packageJson = JSON.parse(readFileSync('package.json', 'utf8')) as {
|
|
scripts?: Record<string, string>
|
|
}
|
|
const prePushHook = readFileSync('scripts/git-hooks/pre-push', 'utf8')
|
|
const contributing = readFileSync('docs/guide/contributing.md', 'utf8')
|
|
const englishContributing = readFileSync('docs/en/guide/contributing.md', 'utf8')
|
|
const rootContributing = readFileSync('CONTRIBUTING.md', 'utf8')
|
|
|
|
expect(packageJson.scripts?.verify).toBe('bun run quality:pr')
|
|
expect(packageJson.scripts?.['quality:verify']).toBe('bun run quality:pr')
|
|
expect(packageJson.scripts?.['quality:push']).toBe('bun run quality:gate --mode pr --skip coverage')
|
|
expect(packageJson.scripts?.['check:persistence-upgrade']).toBe('bun run scripts/quality-gate/persistence-upgrade.ts')
|
|
expect(packageJson.scripts?.['check:native']).toContain('electron:package:dir')
|
|
expect(packageJson.scripts?.['check:native']).toContain('test:package-smoke:current')
|
|
expect(packageJson.scripts?.['test:package-smoke:current']).toBe('bun run scripts/quality-gate/package-smoke/current.ts')
|
|
expect(prePushHook).toContain('bun run quality:push')
|
|
expect(prePushHook).not.toContain('\nbun run quality:pr\n')
|
|
expect(contributing).toContain('bun run verify')
|
|
expect(contributing).toContain('bun run quality:push')
|
|
expect(contributing).toContain('AI Coding Agent 修复循环')
|
|
expect(englishContributing).toContain('bun run verify')
|
|
expect(englishContributing).toContain('bun run quality:push')
|
|
expect(englishContributing).toContain('AI Coding Agent Fix Loop')
|
|
expect(rootContributing).toContain('bun run verify')
|
|
expect(rootContributing).toContain('bun run quality:push')
|
|
})
|
|
|
|
test('keeps desktop native CI aligned with Electron packaging', () => {
|
|
const prQuality = readFileSync('.github/workflows/pr-quality.yml', 'utf8')
|
|
const buildSidecars = readFileSync('desktop/scripts/build-sidecars.ts', 'utf8')
|
|
|
|
expect(prQuality).toContain('run: bun run check:native')
|
|
expect(prQuality).not.toContain('dtolnay/rust-toolchain')
|
|
expect(prQuality).not.toContain('swatinem/rust-cache')
|
|
expect(prQuality).not.toContain('libwebkit2gtk')
|
|
expect(prQuality).not.toContain('libayatana-appindicator')
|
|
expect(buildSidecars).not.toContain("Bun.spawn(['rustc'")
|
|
expect(buildSidecars).toContain("process.platform")
|
|
expect(buildSidecars).toContain("process.arch")
|
|
})
|
|
|
|
test('keeps general AI coding tools pointed at the same quality bar', () => {
|
|
const instructions = readFileSync('.github/copilot-instructions.md', 'utf8')
|
|
|
|
expect(instructions).toContain('Follow the repository contract in `AGENTS.md`')
|
|
expect(instructions).toContain('Add same-area tests with the production change')
|
|
expect(instructions).toContain('Preserve or improve the coverage ratchet')
|
|
expect(instructions).toContain('changed-line coverage threshold')
|
|
expect(instructions).toContain('E2E or agent-browser smoke')
|
|
expect(instructions).toContain('include changed files, tests added, coverage report path')
|
|
})
|
|
})
|