mirror of
https://github.com/NanmiCoder/cc-haha
synced 2026-07-16 13:03:31 +08:00
6ca7ee48a8
Desktop destructive confirmations had split implementations: shared ConfirmDialog, hand-rolled modals, inline task popovers, and a diagnostics window.confirm path. This adds shared ActionDialog and ConfirmPopover primitives, keeps ConfirmDialog as the simple two-action wrapper, and migrates the known desktop confirmation flows onto those shared surfaces. Constraint: Running-tab close needs three actions, so the two-button ConfirmDialog API was not enough. Rejected: Force every confirmation through ConfirmDialog | would either lose the keep-running action or make ConfirmDialog too broad for inline popovers. Confidence: high Scope-risk: moderate Directive: Add new desktop confirmation flows through ActionDialog, ConfirmDialog, or ConfirmPopover instead of hand-rolled overlays. Tested: cd desktop && bun run test -- AdapterSettings.test.tsx mcpSettings.test.tsx TabBar.test.tsx PermissionModeSelector.test.tsx diagnosticsSettings.test.tsx Tested: bun run check:desktop Tested: git diff --check Tested: Chrome DevTools smoke for provider delete and diagnostics clear-log confirmation dialogs Not-tested: Agent Browser smoke because the local agent-browser CLI hung on open/snapshot/doctor/close commands.