mirror of
https://github.com/NanmiCoder/cc-haha
synced 2026-07-16 13:03:31 +08:00
6b4f7e4733
Reveal-in-Explorer/Finder rejected ~-prefixed paths because no layer expanded the tilde to the home directory. Expand it in the three path normalization entry points: server validateOpenPath, frontend resolveAbsolute, and Electron normalizeOpenPath. Tilde expansion is platform-aware (~\ only on win32, where backslash is a separator).
61 lines
3.1 KiB
TypeScript
61 lines
3.1 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import { chmodSync, mkdtempSync, mkdirSync, realpathSync, rmSync, writeFileSync } from 'node:fs'
|
|
import { homedir, tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import { expandTildePath, normalizeExternalUrl, normalizeOpenPath, normalizeSystemSettingsUrl } from './shell'
|
|
|
|
describe('Electron shell service', () => {
|
|
it('allows only explicit external URL schemes', () => {
|
|
expect(normalizeExternalUrl('https://example.com/path')).toBe('https://example.com/path')
|
|
expect(normalizeExternalUrl('mailto:support@example.com')).toBe('mailto:support@example.com')
|
|
expect(() => normalizeExternalUrl('file:///tmp/report.md')).toThrow('Unsupported external URL scheme')
|
|
expect(() => normalizeExternalUrl('/tmp/report.md')).toThrow('absolute URLs')
|
|
})
|
|
|
|
it('allows only existing non-executable file-system paths for openPath', () => {
|
|
const rootDir = mkdtempSync(join(tmpdir(), 'electron-shell-'))
|
|
const reportPath = join(rootDir, 'report.md')
|
|
const folderPath = join(rootDir, 'folder')
|
|
const scriptPath = join(rootDir, 'run.sh')
|
|
const appPath = join(rootDir, 'Tool.app')
|
|
try {
|
|
writeFileSync(reportPath, 'ok')
|
|
mkdirSync(folderPath)
|
|
writeFileSync(scriptPath, '#!/bin/sh\n')
|
|
chmodSync(scriptPath, 0o755)
|
|
mkdirSync(appPath)
|
|
|
|
expect(normalizeOpenPath(reportPath)).toBe(realpathSync(reportPath))
|
|
expect(normalizeOpenPath(new URL(`file://${reportPath}`).toString())).toBe(realpathSync(reportPath))
|
|
expect(normalizeOpenPath(folderPath)).toBe(realpathSync(folderPath))
|
|
expect(() => normalizeOpenPath(scriptPath)).toThrow('executable')
|
|
expect(() => normalizeOpenPath(appPath)).toThrow('executable')
|
|
} finally {
|
|
rmSync(rootDir, { recursive: true, force: true })
|
|
}
|
|
expect(() => normalizeOpenPath('relative/report.md')).toThrow('absolute')
|
|
})
|
|
|
|
it('expands tilde paths per platform', () => {
|
|
expect(expandTildePath('~', 'darwin')).toBe(homedir())
|
|
expect(expandTildePath('~/reports/a.html', 'linux')).toBe(`${homedir()}/reports/a.html`)
|
|
expect(expandTildePath('~\\reports\\a.html', 'win32')).toBe(`${homedir()}\\reports\\a.html`)
|
|
// On POSIX "~\..." is a regular file name; "~user" expansion is unsupported.
|
|
expect(expandTildePath('~\\reports\\a.html', 'darwin')).toBe('~\\reports\\a.html')
|
|
expect(expandTildePath('~user/file.md', 'linux')).toBe('~user/file.md')
|
|
expect(expandTildePath('a/~/b.md', 'linux')).toBe('a/~/b.md')
|
|
})
|
|
|
|
it('expands tilde paths before the absolute-path check in openPath', () => {
|
|
expect(normalizeOpenPath('~')).toBe(realpathSync(homedir()))
|
|
})
|
|
|
|
it('allows only explicit system settings URLs', () => {
|
|
expect(normalizeSystemSettingsUrl('ms-settings:notifications')).toBe('ms-settings:notifications')
|
|
expect(normalizeSystemSettingsUrl('x-apple.systempreferences:com.apple.preference.notifications')).toBe(
|
|
'x-apple.systempreferences:com.apple.preference.notifications',
|
|
)
|
|
expect(() => normalizeSystemSettingsUrl('ms-settings:privacy')).toThrow('Unsupported system settings URL')
|
|
})
|
|
})
|