From fff08ee54582175ea95dd6499f382ac1e9b96ff6 Mon Sep 17 00:00:00 2001 From: YanZhiwei Date: Sun, 12 Apr 2026 21:12:53 +0800 Subject: [PATCH] fix: address PR review issues for Azure Codex integration --- src/services/api/azureOpenAI.ts | 8 +++++++- src/services/api/claude.ts | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/services/api/azureOpenAI.ts b/src/services/api/azureOpenAI.ts index ad040f50..5b3e2071 100644 --- a/src/services/api/azureOpenAI.ts +++ b/src/services/api/azureOpenAI.ts @@ -105,7 +105,13 @@ export function resolveAzureOpenAIDeployment(model: string): string { const codex = resolveCodexDeployment(trimmed) if (codex) { - if (codex === trimmed || codex.toLowerCase().includes('codex')) { + const codexLower = codex.toLowerCase() + if ( + codex === trimmed || + codexLower === 'gpt-5.2-codex' || + codexLower === 'gpt-5.3-codex' || + codexLower === 'gpt-5.4-codex' + ) { throw new Error( `Missing Azure OpenAI deployment mapping for ${trimmed}. Set AZURE_OPENAI_CODEX_DEPLOYMENT or settings.modelOverrides["${trimmed}"] to your deployment name.`, ) diff --git a/src/services/api/claude.ts b/src/services/api/claude.ts index 7e2e695c..6795a6d2 100644 --- a/src/services/api/claude.ts +++ b/src/services/api/claude.ts @@ -1028,7 +1028,7 @@ async function* queryModel( > { if (getAPIProvider() === 'azureOpenAI') { try { - const systemText = systemPrompt.join('\\n') + const systemText = systemPrompt.join('\n') const maxOutputTokens = options.maxOutputTokensOverride ?? getModelMaxOutputTokens(options.model).default