From f53af6c14d99b79d49bf847d699eb7a0949a3be2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=B0=8F=E6=A9=99=E5=AD=90?= <113168461+706412584@users.noreply.github.com> Date: Tue, 16 Jun 2026 17:49:26 +0800 Subject: [PATCH] fix(release): wire build:plugin-seed into the local platform build scripts (#59) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR #58 fixed the GitHub workflows but missed the three local platform build scripts that maintainers run to reproduce the release locally (build-windows-x64.ps1, build-macos-arm64.sh, build-linux.sh). Those scripts inline the same `bun run build && bun run build:electron` sequence — without the seed step — so a `bun run build:windows-x64` on a maintainer machine produced an installer with the same "not found in marketplace cc-haha-builtin" failure as the official seedless release. Add `bun run build:plugin-seed` ahead of `build` in all three scripts. Verified locally: ran `bun run build:windows-x64`, package-smoke reported the new "Windows unpacked cc-haha-builtin plugin seed" check as PASS, and the produced desktop/build-artifacts/windows-x64/win-unpacked/resources/app.asar.unpacked/plugin-seed/marketplaces/cc-haha-builtin/.claude-plugin/marketplace.json contains both reverse-engineering and image-gen plugin entries with their copied source directories. Confidence: high Scope-risk: narrow (build-script-only; package-smoke gate from PR #58 already enforces the seed presence in the artifact). Co-authored-by: 你的姓名 --- desktop/scripts/build-linux.sh | 2 +- desktop/scripts/build-macos-arm64.sh | 2 +- desktop/scripts/build-windows-x64.ps1 | 4 ++++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/desktop/scripts/build-linux.sh b/desktop/scripts/build-linux.sh index 17549e5e..9e0f9dff 100755 --- a/desktop/scripts/build-linux.sh +++ b/desktop/scripts/build-linux.sh @@ -87,7 +87,7 @@ echo "[build-linux] Building sidecars for ${TARGET_TRIPLE}..." (cd "${DESKTOP_DIR}" && SIDECAR_TARGET_TRIPLE="${TARGET_TRIPLE}" bun run build:sidecars) echo "[build-linux] Building renderer and Electron main/preload bundles..." -(cd "${DESKTOP_DIR}" && bun run build && bun run build:electron) +(cd "${DESKTOP_DIR}" && bun run build:plugin-seed && bun run build && bun run build:electron) if [[ "${REBUILD_NATIVE:-0}" == "1" ]]; then echo "[build-linux] Rebuilding native dependencies for Electron ABI..." diff --git a/desktop/scripts/build-macos-arm64.sh b/desktop/scripts/build-macos-arm64.sh index 44e1029a..b3a8ecad 100755 --- a/desktop/scripts/build-macos-arm64.sh +++ b/desktop/scripts/build-macos-arm64.sh @@ -100,7 +100,7 @@ echo "[build-macos-arm64] Building sidecars for ${TARGET_TRIPLE}..." (cd "${DESKTOP_DIR}" && SIDECAR_TARGET_TRIPLE="${TARGET_TRIPLE}" bun run build:sidecars) echo "[build-macos-arm64] Building renderer and Electron main/preload bundles..." -(cd "${DESKTOP_DIR}" && bun run build && bun run build:electron) +(cd "${DESKTOP_DIR}" && bun run build:plugin-seed && bun run build && bun run build:electron) if [[ "${REBUILD_NATIVE:-0}" == "1" ]]; then echo "[build-macos-arm64] Rebuilding native dependencies for Electron ABI..." diff --git a/desktop/scripts/build-windows-x64.ps1 b/desktop/scripts/build-windows-x64.ps1 index 5f4029bb..41fa519f 100644 --- a/desktop/scripts/build-windows-x64.ps1 +++ b/desktop/scripts/build-windows-x64.ps1 @@ -127,6 +127,10 @@ try { } Write-Step 'Building renderer and Electron main/preload bundles...' + & bun run build:plugin-seed + if ($LASTEXITCODE -ne 0) { + throw "[build-windows-x64] build:plugin-seed failed (exit $LASTEXITCODE)" + } & bun run build if ($LASTEXITCODE -ne 0) { throw "[build-windows-x64] renderer build failed (exit $LASTEXITCODE)"