From ee480e0ceefe17723ae45375bcecaea68b322321 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=A8=8B=E5=BA=8F=E5=91=98=E9=98=BF=E6=B1=9F=28Relakkes?= =?UTF-8?q?=29?= Date: Wed, 17 Jun 2026 02:13:18 +0800 Subject: [PATCH] fix(release): skip non-code macOS signing resources Tested: bun test scripts/pr/release-workflow.test.ts Tested: git diff --check Tested: bun run scripts/release.ts 0.4.3 --dry Tested: env DEBUG=electron-builder,electron-osx-sign node ./node_modules/electron-builder/out/cli/cli.js --mac zip --arm64 --publish never -c.mac.notarize=false Tested: bun run test:package-smoke --platform macos --package-kind release --artifacts-dir desktop/build-artifacts/electron Confidence: high Scope-risk: narrow --- desktop/package.json | 4 ++++ scripts/pr/release-workflow.test.ts | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/desktop/package.json b/desktop/package.json index dd711498..90a2a9c9 100644 --- a/desktop/package.json +++ b/desktop/package.json @@ -44,6 +44,10 @@ "gatekeeperAssess": false, "entitlements": "build/entitlements.mac.plist", "entitlementsInherit": "build/entitlements.mac.inherit.plist", + "signIgnore": [ + "/Contents/Frameworks/.+\\.(?:pak|bin|dat|nib)$", + "/Contents/Resources/.+\\.(?:asar|pak|bin|dat|icns|png|jpg|jpeg|gif|svg|ttf|woff|woff2)$" + ], "notarize": true }, "win": { diff --git a/scripts/pr/release-workflow.test.ts b/scripts/pr/release-workflow.test.ts index 3b7f27f2..654719b7 100644 --- a/scripts/pr/release-workflow.test.ts +++ b/scripts/pr/release-workflow.test.ts @@ -380,6 +380,7 @@ describe('release desktop workflow', () => { notarize?: boolean entitlements?: string entitlementsInherit?: string + signIgnore?: string[] } } } @@ -389,6 +390,10 @@ describe('release desktop workflow', () => { expect(desktopPackage.build.mac?.notarize).toBe(true) expect(desktopPackage.build.mac?.entitlements).toBe('build/entitlements.mac.plist') expect(desktopPackage.build.mac?.entitlementsInherit).toBe('build/entitlements.mac.inherit.plist') + expect(desktopPackage.build.mac?.signIgnore).toEqual([ + '/Contents/Frameworks/.+\\.(?:pak|bin|dat|nib)$', + '/Contents/Resources/.+\\.(?:asar|pak|bin|dat|icns|png|jpg|jpeg|gif|svg|ttf|woff|woff2)$', + ]) }) test('Windows NSIS installer lets users choose the install directory', () => {