sdaduanbilei/cc-haha
1
0
Fork 0
mirror of https://github.com/NanmiCoder/cc-haha synced 2026-08-02 16:51:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Stabilize chat scroll tests for release gate

Browse Source 
The release push gate exposed that the MessageList scroll tests fired synthetic user scrolls before the component's programmatic auto-scroll guard had reset. Waiting for the requestAnimationFrame reset keeps the tests aligned with the runtime behavior where users cannot scroll in the same frame as mount auto-scroll.

Constraint: Pre-push quality gate must pass before publishing the release tag
Rejected: Bypass pre-push verification | would publish without the repo's required PR quality evidence
Confidence: high
Scope-risk: narrow
Tested: cd desktop && bun run test -- src/components/chat/MessageList.test.tsx --run
Tested: bun run check:desktop
Tested: bun run check:coverage
Not-tested: Full bun run quality:pr after this commit; it will run again during push
This commit is contained in:
程序员阿江(Relakkes) 2026-05-10 22:53:23 +08:00
parent 2950cef662
commit d37d752310
1 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
desktop/src/components/chat/MessageList.test.tsx
View File

@ -11,6 +11,14 @@ import type { PerSessionState } from '../../stores/chatStore'
const ACTIVE_TAB = 'active-tab' const ACTIVE_TAB = 'active-tab'
async function waitForProgrammaticScrollReset() {
await act(async () => {
await new Promise<void>((resolve) => {
requestAnimationFrame(() => resolve())
})
})
}
function makeSessionState(overrides: Partial<PerSessionState> = {}): PerSessionState { function makeSessionState(overrides: Partial<PerSessionState> = {}): PerSessionState {
return { return {
messages: [], messages: [],
@ -459,6 +467,7 @@ describe('MessageList nested tool calls', () => {
}) })
scrollIntoView.mockClear() scrollIntoView.mockClear()
await waitForProgrammaticScrollReset()
fireEvent.scroll(scroller) fireEvent.scroll(scroller)
act(() => { act(() => {
@ -517,6 +526,7 @@ describe('MessageList nested tool calls', () => {
}) })
scrollIntoView.mockClear() scrollIntoView.mockClear()
await waitForProgrammaticScrollReset()
fireEvent.scroll(scroller) fireEvent.scroll(scroller)
act(() => { act(() => {
@ -581,6 +591,7 @@ describe('MessageList nested tool calls', () => {
}, },
}) })
await waitForProgrammaticScrollReset()
fireEvent.scroll(scroller) fireEvent.scroll(scroller)
expect(screen.getByRole('button', { name: 'Latest' })).toBeTruthy() expect(screen.getByRole('button', { name: 'Latest' })).toBeTruthy()
@ -592,6 +603,7 @@ describe('MessageList nested tool calls', () => {
}) })
scrollTop = 760 scrollTop = 760
await waitForProgrammaticScrollReset()
fireEvent.scroll(scroller) fireEvent.scroll(scroller)
act(() => { act(() => {
@ -697,6 +709,7 @@ describe('MessageList nested tool calls', () => {
}) })
scrollIntoView.mockClear() scrollIntoView.mockClear()
await waitForProgrammaticScrollReset()
fireEvent.scroll(scroller) fireEvent.scroll(scroller)
fireEvent.click(screen.getByRole('button', { name: 'Latest' })) fireEvent.click(screen.getByRole('button', { name: 'Latest' }))