From 669be1fbc6a5f28306c6aca9d10a9c56caa4b955 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=A8=8B=E5=BA=8F=E5=91=98=E9=98=BF=E6=B1=9F=28Relakkes?= =?UTF-8?q?=29?= Date: Fri, 17 Apr 2026 20:19:31 +0800 Subject: [PATCH] fix(desktop): align conversationService log format + document deferred import MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Code review follow-up on 94b445c: - console.error 改用 err instanceof Error ? err.message : err (跟 hahaOAuthService 一致) - dynamic import hahaOAuthService 加注释说明 defer 目的 Co-Authored-By: Claude Opus 4.7 (1M context) --- src/server/services/conversationService.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/server/services/conversationService.ts b/src/server/services/conversationService.ts index 46dfae77..4b9ce831 100644 --- a/src/server/services/conversationService.ts +++ b/src/server/services/conversationService.ts @@ -528,13 +528,18 @@ export class ConversationService { CLAUDE_CODE_ENTRYPOINT: 'claude-desktop', } try { + // deferred import: avoids instantiating the OAuth singleton on every + // ConversationService construction — only loaded when official mode hits. const { hahaOAuthService } = await import('./hahaOAuthService.js') const token = await hahaOAuthService.ensureFreshAccessToken() if (token) { env.CLAUDE_CODE_OAUTH_TOKEN = token } } catch (err) { - console.error('[conversationService] ensureFreshAccessToken failed:', err) + console.error( + '[conversationService] ensureFreshAccessToken failed:', + err instanceof Error ? err.message : err, + ) } return env }