sdaduanbilei/cc-haha
1
0
Fork 0
mirror of https://github.com/NanmiCoder/cc-haha synced 2026-07-16 13:03:31 +08:00
Code Issues Packages Projects Releases Wiki Activity

Trigger Dosu from PR triage comments

Browse Source 
The PR triage workflow mentioned Dosu inside inline-code formatting and before the final footer, which did not reliably wake the bot. Move the handoff so the last non-empty comment line is a plain-text @dosubot request, matching the working PR template pattern.

Constraint: GitHub bot mentions can be sensitive to markdown formatting and comment placement.

Rejected: Leave the mention as a copy-paste hint | it does not satisfy the maintainer need for automatic bot triggering.

Confidence: high

Scope-risk: narrow

Directive: Keep the generated triage comment's final non-empty line as a plain-text @dosubot request.

Tested: bun run check:policy

Tested: git diff --check

Tested: bun run check:pr
This commit is contained in:
程序员阿江(Relakkes) 2026-05-02 22:07:03 +08:00
parent 7a5f813601
commit 5b2b5c0d1a
3 changed files with 32 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/pr-triage.yml vendored
View File

@ -227,11 +227,11 @@ jobs:
'**Risk notes:**',
riskNotes.map((note) => `- ${note}`).join('\n'),
'',
'Hard merge gates still come from GitHub Actions, not AI review.',
'',
'**Dosu handoff:** Dosu can be used as the AI reviewer for risk explanation, missing-test prompts, and maintainer Q&A. If it does not comment automatically from the PR template, ask:',
'',
'`@dosubot review this PR for changed-area risk, missing tests, docs impact, desktop startup risk, and CLI core impact.`',
'',
'Hard merge gates still come from GitHub Actions, not AI review.',
'@dosubot review this PR for changed-area risk, missing tests, docs impact, desktop startup risk, and CLI core impact.',
].join('\n')
const comments = await github.paginate(github.rest.issues.listComments, {

2
package.json
View File

@ -11,7 +11,7 @@
"start": "bun run ./bin/claude-haha",
"check:pr": "bun run scripts/pr/check-pr.ts",
"check:impact": "bun run scripts/pr/impact-report.ts",
"check:policy": "bun test scripts/pr/change-policy.test.ts",
"check:policy": "bun test scripts/pr/change-policy.test.ts scripts/pr/pr-triage-workflow.test.ts",
"check:server": "bun run scripts/pr/run-server-tests.ts",
"check:desktop": "cd desktop && bun run lint && bun run test -- --run && bun run build",
"check:adapters": "cd adapters && bun test",

28
scripts/pr/pr-triage-workflow.test.ts Normal file
View File

@ -0,0 +1,28 @@
import { describe, expect, test } from 'bun:test'
import { readFileSync } from 'node:fs'
const DOSU_PROMPT = '@dosubot review this PR for changed-area risk, missing tests, docs impact, desktop startup risk, and CLI core impact.'
function extractCommentBodyEntries(workflow: string) {
const match = workflow.match(/const body = \[([\s\S]*?)\n\s*\]\.join\('\\n'\)/)
if (!match) {
throw new Error('Could not find PR triage comment body array')
}
return match[1]
.split('\n')
.map((line) => line.trim())
.filter((line) => line.startsWith("'") || line.startsWith('`'))
}
describe('PR triage workflow comment', () => {
test('ends with a plain-text Dosu mention so the bot is triggered', () => {
const workflow = readFileSync('.github/workflows/pr-triage.yml', 'utf8')
const entries = extractCommentBodyEntries(workflow)
const nonEmptyEntries = entries.filter((entry) => !/^['`]['`],?$/.test(entry))
const lastEntry = nonEmptyEntries.at(-1)
expect(lastEntry).toBe(`'${DOSU_PROMPT}',`)
expect(workflow).not.toContain(`\`${DOSU_PROMPT}\``)
})
})