From 3fc6b7f7dfc5c9360438e42ff0cd4b27bcb83b91 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=A8=8B=E5=BA=8F=E5=91=98=E9=98=BF=E6=B1=9F=28Relakkes?= =?UTF-8?q?=29?= Date: Sat, 4 Jul 2026 22:14:03 +0800 Subject: [PATCH] fix: avoid misleading skill card preview badge --- desktop/src/i18n/locales/en.ts | 3 +-- desktop/src/i18n/locales/jp.ts | 3 +-- desktop/src/i18n/locales/kr.ts | 3 +-- desktop/src/i18n/locales/zh-TW.ts | 3 +-- desktop/src/i18n/locales/zh.ts | 3 +-- desktop/src/pages/SkillCenter.test.tsx | 5 +++-- desktop/src/pages/SkillCenter.tsx | 19 +++++-------------- 7 files changed, 13 insertions(+), 26 deletions(-) diff --git a/desktop/src/i18n/locales/en.ts b/desktop/src/i18n/locales/en.ts index e072495b..210e20db 100644 --- a/desktop/src/i18n/locales/en.ts +++ b/desktop/src/i18n/locales/en.ts @@ -2056,8 +2056,7 @@ export const en = { 'skillCenter.marketplace.sort.updated': 'Updated', 'skillCenter.marketplace.sort.trending': 'Trending', 'skillCenter.marketplace.installedBadge': 'Installed', - 'skillCenter.marketplace.previewAvailable': 'Preview', - 'skillCenter.marketplace.noPreviewBadge': 'No preview', + 'skillCenter.marketplace.detailsBadge': 'Details', 'skillCenter.marketplace.cardMeta.downloads': '{count} downloads', 'skillCenter.marketplace.cardMeta.stars': '{count} stars', 'skillCenter.marketplace.trust.clean': 'Clean', diff --git a/desktop/src/i18n/locales/jp.ts b/desktop/src/i18n/locales/jp.ts index 8796da8a..ea66d1b2 100644 --- a/desktop/src/i18n/locales/jp.ts +++ b/desktop/src/i18n/locales/jp.ts @@ -2058,8 +2058,7 @@ export const jp: Record = { 'skillCenter.marketplace.sort.updated': '更新日時', 'skillCenter.marketplace.sort.trending': '人気', 'skillCenter.marketplace.installedBadge': 'インストール済み', - 'skillCenter.marketplace.previewAvailable': 'プレビュー', - 'skillCenter.marketplace.noPreviewBadge': 'プレビューなし', + 'skillCenter.marketplace.detailsBadge': '詳細', 'skillCenter.marketplace.cardMeta.downloads': '{count} ダウンロード', 'skillCenter.marketplace.cardMeta.stars': '{count} スター', 'skillCenter.marketplace.trust.clean': '安全', diff --git a/desktop/src/i18n/locales/kr.ts b/desktop/src/i18n/locales/kr.ts index 24abe59d..37ec10c6 100644 --- a/desktop/src/i18n/locales/kr.ts +++ b/desktop/src/i18n/locales/kr.ts @@ -2058,8 +2058,7 @@ export const kr: Record = { 'skillCenter.marketplace.sort.updated': '업데이트', 'skillCenter.marketplace.sort.trending': '인기', 'skillCenter.marketplace.installedBadge': '설치됨', - 'skillCenter.marketplace.previewAvailable': '미리보기', - 'skillCenter.marketplace.noPreviewBadge': '미리보기 없음', + 'skillCenter.marketplace.detailsBadge': '세부 정보', 'skillCenter.marketplace.cardMeta.downloads': '{count} 다운로드', 'skillCenter.marketplace.cardMeta.stars': '{count} 스타', 'skillCenter.marketplace.trust.clean': '안전', diff --git a/desktop/src/i18n/locales/zh-TW.ts b/desktop/src/i18n/locales/zh-TW.ts index b914cb84..0bf1c781 100644 --- a/desktop/src/i18n/locales/zh-TW.ts +++ b/desktop/src/i18n/locales/zh-TW.ts @@ -2058,8 +2058,7 @@ export const zh: Record = { 'skillCenter.marketplace.sort.updated': '最近更新', 'skillCenter.marketplace.sort.trending': '熱門', 'skillCenter.marketplace.installedBadge': '已安裝', - 'skillCenter.marketplace.previewAvailable': '可預覽', - 'skillCenter.marketplace.noPreviewBadge': '無預覽', + 'skillCenter.marketplace.detailsBadge': '檢視詳情', 'skillCenter.marketplace.cardMeta.downloads': '{count} 次下載', 'skillCenter.marketplace.cardMeta.stars': '{count} 星標', 'skillCenter.marketplace.trust.clean': '安全', diff --git a/desktop/src/i18n/locales/zh.ts b/desktop/src/i18n/locales/zh.ts index a2f34005..27640350 100644 --- a/desktop/src/i18n/locales/zh.ts +++ b/desktop/src/i18n/locales/zh.ts @@ -2058,8 +2058,7 @@ export const zh: Record = { 'skillCenter.marketplace.sort.updated': '最近更新', 'skillCenter.marketplace.sort.trending': '热门', 'skillCenter.marketplace.installedBadge': '已安装', - 'skillCenter.marketplace.previewAvailable': '可预览', - 'skillCenter.marketplace.noPreviewBadge': '无预览', + 'skillCenter.marketplace.detailsBadge': '查看详情', 'skillCenter.marketplace.cardMeta.downloads': '{count} 次下载', 'skillCenter.marketplace.cardMeta.stars': '{count} 星标', 'skillCenter.marketplace.trust.clean': '安全', diff --git a/desktop/src/pages/SkillCenter.test.tsx b/desktop/src/pages/SkillCenter.test.tsx index 9c8469c8..b3f7a4c2 100644 --- a/desktop/src/pages/SkillCenter.test.tsx +++ b/desktop/src/pages/SkillCenter.test.tsx @@ -185,7 +185,7 @@ describe('SkillCenter', () => { }) }) - it('renders marketplace cards with trust, preview, install, API key, and popularity signals', async () => { + it('renders marketplace cards with trust, details, install, API key, and popularity signals', async () => { mockedSkillMarketApi.list.mockResolvedValue({ items: [ makeItem({ @@ -227,7 +227,8 @@ describe('SkillCenter', () => { const crmCard = within(market).getByRole('button', { name: 'CRM Sync' }) expect(vetterCard).toBeInTheDocument() expect(within(market).getAllByText('Clean').length).toBeGreaterThan(0) - expect(within(market).getAllByText('Preview').length).toBeGreaterThan(0) + expect(within(market).queryByText('Preview')).not.toBeInTheDocument() + expect(within(vetterCard).getByText('Details')).toBeInTheDocument() expect(within(weatherCard).getByText('Installed')).toBeInTheDocument() expect(within(crmCard).getByText('API key')).toBeInTheDocument() expect(within(vetterCard).getByText(/260\.9K|260,960/)).toBeInTheDocument() diff --git a/desktop/src/pages/SkillCenter.tsx b/desktop/src/pages/SkillCenter.tsx index eaaf3c9b..9ba28923 100644 --- a/desktop/src/pages/SkillCenter.tsx +++ b/desktop/src/pages/SkillCenter.tsx @@ -582,7 +582,6 @@ function SkillMarketCard({ const stats = formatStats(item, t) const sourceLabel = t(`skillCenter.marketplace.source.${item.source}`) const summary = item.summaryZh || item.summary - const hasPreview = Boolean(item.trustSummary || item.summary || item.summaryZh) return (